refactor!: split bls and secp256k1 private key #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
changed the title
KaoImin
force-pushed
the
split-off-private-key
branch
from
7ec2f5c to
1471fcf
Compare
KaoImin
force-pushed
the
split-off-private-key
branch
from
1471fcf to
b56e345
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
driftluo
previously approved these changes
Oct 11, 2023
6 tasks
Flouse
requested changes
Oct 11, 2023
Flouse
reviewed
Oct 11, 2023
Flouse
reviewed
Oct 11, 2023
KaoImin
force-pushed
the
split-off-private-key
branch
from
b56e345 to
2b683f2
Compare
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
approved these changes
Oct 12, 2023
driftluo
approved these changes
Oct 12, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR split the bls and secp256k1 private key.
The bls public key and secp256k1 used to keep a same private key and generate their own public key. Although there are no studies that show the safety risks of this behavior, we intend to change this. The config file is now add a
bls_private_keyfield, this private key only used to sign the consensus messages.Notice: The
addressinValidatorlist is calculate bysecp256k1public key, axon will never useblspublic key to calculate address.PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description